Initial matcher/validator support #122
Conversation
| } | ||
|
|
||
| func testMatchReplace() { | ||
| let regex = Regex(OneOrMore(.digit).capture { Int($0)! }) |
There was a problem hiding this comment.
It would be great if we get additional examples of find-and-replace with a regex with multiple captures, both with the regex literal and with the result builder syntax. That will help inform our decisions around Swift tuples vs nominal tuples.
timvermeulen
force-pushed
the
matchers
branch
from
511d216 to
e89dcbb
Compare
|
@swift-ci Please test Linux |
| @@ -9,56 +9,54 @@ | |||
| // | |||
| //===----------------------------------------------------------------------===// | |||
|
|
|||
| import _MatchingEngine | |||
| public struct RegexConsumer< | |||
There was a problem hiding this comment.
This looks fine to me for now.
Outside scope of this PR, we might make RegexProtocol itself a consumer/searcher/matcher. But, I think it's best to establish parent-child relationships after we have the fundamental model in place. The important thing is getting this code and conformances in.
BTW, why does this need to be public?
There was a problem hiding this comment.
Some consumer/searcher algorithms return a type generic over the searcher, so the regex overloads return a type generic over RegexConsumer. So same story as PredicateConsumer at the moment.
* Initial matchers support * Conform `RegexConsumer` to the matcher protocols * Add `firstMatch`/`lastMatch` and match find/replace * Add `_MatchResult` and allow `RegexProtocol` in algorithms
Adds
MatchingCollectionConsumerandMatchingCollectionSearcheras a matching/validating analogues ofCollectionConsumerandCollectionSearcher:...as well as matching equivalents of the other consumer/searcher protocols.
Also adds a few algorithms that work with matches:
firstMatch/lastMatchmatches(of:)replacing(_:with:)using a closure: